feat: expose parameter registration interface #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes a parameter registration interface, allowing for a more flexible approach to adding parameters for cucumber expressions.
- Introduces a new interface, ParameterRegistration, with a pure virtual Add method.
- Updates ParameterRegistry to inherit from ParameterRegistration and replaces AddParameter with Add.
- Exposes the parameter registration interface via Application.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cucumber_cpp/library/cucumber_expression/ParameterRegistry.hpp | Renamed and added interface for parameter registration; updated method signature to Add. |
| cucumber_cpp/library/cucumber_expression/ParameterRegistry.cpp | Replaced calls to AddParameter with Add, in line with the new interface. |
| cucumber_cpp/library/Application.hpp | Added accessor method for the parameter registration interface. |
| cucumber_cpp/library/Application.cpp | Exposed the parameter registry via the new accessor method. |
Comments suppressed due to low confidence (2)
cucumber_cpp/library/cucumber_expression/ParameterRegistry.hpp:123
- [nitpick] Consider renaming 'ParameterRegistration' to 'IParameterRegistry' to clearly indicate that this struct is an interface.
struct ParameterRegistration
cucumber_cpp/library/Application.hpp:48
- [nitpick] Consider renaming the accessor method to 'GetParameterRegistration()' for improved clarity and consistency with naming conventions for accessor functions.
cucumber_expression::ParameterRegistration& ParameterRegistration();
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports
|
daantimmer
force-pushed
the
feature/expose-parameter-registration-interface
branch
3 times, most recently
from
b59f31a to
eed61b7
Compare
daantimmer
force-pushed
the
feature/expose-parameter-registration-interface
branch
from
eed61b7 to
cced049
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…or better encapsulation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.